Cleanup: put next_byte in token rather than first_byte#21
Merged
Conversation
While a bit counter-intuitive, this enables us to use an initial sentinel token for recording the first byte of the first real token which removes a bunch of special case hacks for computing the last byte of the current output token. Also return only SyntaxHead from peek_token() - the byte range is never needed.
c42f
force-pushed
the
cjf/token-byte-cleanups
branch
from
96b10d6 to
10a4164
Compare
c42f
added a commit
to JuliaLang/julia
that referenced
this pull request
Oct 17, 2025
…iaSyntax.jl#21) While a bit counter-intuitive, this enables us to use an initial sentinel token for recording the first byte of the first real token which removes a bunch of special case hacks for computing the last byte of the current output token. Also return only SyntaxHead from peek_token() - the byte range is never needed.
topolarity
pushed a commit
to JuliaLang/julia
that referenced
this pull request
Nov 14, 2025
…iaSyntax.jl#21) While a bit counter-intuitive, this enables us to use an initial sentinel token for recording the first byte of the first real token which removes a bunch of special case hacks for computing the last byte of the current output token. Also return only SyntaxHead from peek_token() - the byte range is never needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While a bit counter-intuitive, this enables us to use an initial
sentinel token for recording the first byte of the first real token
which removes a bunch of special case hacks for computing the last byte
of the current output token.