Revert "sort for NTuple and other iterables (#804)"

[martinholters]

This reverts commit c59d116. Closes #811.

This is likely to break NDTensors, but might still be considered a bugfix as it makes Compat behave more like most recent Julia, see discussion in #811.

[ericphanson]

To run nanosoldier on this PR, a Compat.jl admin needs to get a secret from @maleadt to install the webhook on the repo: https://github.com/JuliaCI/Nanosoldier.jl/tree/master/res#repository-configuration. Then you can trigger it following https://github.com/JuliaCI/Nanosoldier.jl#reverse-ci-for-packages

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (db2077e) 92.83% compared to head (165e032) 95.34%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #812      +/-   ##
==========================================
+ Coverage   92.83%   95.34%   +2.51%     
==========================================
  Files           2        2              
  Lines         335      301      -34     
==========================================
- Hits          311      287      -24     
+ Misses         24       14      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[martinholters]

To run nanosoldier on this PR, a Compat.jl admin needs to get a secret from @maleadt to install the webhook on the repo: https://github.com/JuliaCI/Nanosoldier.jl/tree/master/res#repository-configuration. Then you can trigger it following https://github.com/JuliaCI/Nanosoldier.jl#reverse-ci-for-packages

Ah. @KristofferC are you an admin for this repo and can you do that?

[KristofferC]

Let's try this:

@nanosoldier runtests()

[nanosoldier]

Update on PkgEvalJob 165e032 vs. db2077e: Accepted

[LilithHafner]

From the readme

Features in the development versions of julia may be added and released in Compat.jl. However, such features are considered experimental until the relevant julia version is released. These features can be changed or removed without incrementing the major version of Compat.jl if necessary to match changes in julia.

So this revert is explicitly allowed by the declared public API and therefore does not require a major version bump. Any packages that depended on this were depending on experimental features. Whether or not nanosoldier reports breakage this LGTM (unless the entire ecosystem breaks)

This should also be reverted on the 3.x branch. EDIT: it was never on the 3.x branch.

[nanosoldier]

Update on PkgEvalJob 165e032 vs. db2077e: Running

[nanosoldier]

The package evaluation job you requested has completed - possible new issues were detected.
The full report is available.

[martinholters]

Two PkgEval failures (ITensorVisualizationBase and ITensorGaussianMPS), both caused by

    [1] permutedims_combine_output(...)
      @ NDTensors ~/.julia/packages/NDTensors/kR4oQ/src/blocksparse/blocksparsetensor.jl:439

Thanks to @LilithHafner for actually reading the README, I'm totally fine with merging this, but we might want to give a heads-up at NDTensors.