similar(::PermutedDimsArray) #693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinholters
approved these changes
Apr 29, 2020
Member
martinholters
left a comment
martinholters
left a comment
There was a problem hiding this comment.
LGTM but needs conflicts to be resolved and should wait for #695 (also with resolving the conflicts). After merging this one, we tag 3.9.0.
Member
|
Ok, should be good to go now. |
Contributor
Author
|
Thanks for doing the merge, looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds JuliaLang/julia#35304, originally for JuliaGPU/CuArrays.jl#658