Skip to content

bugfix imshow for non-colorant arrays. fixes #10 #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Evizero merged 1 commit into from
Apr 21, 2017
Merged

bugfix imshow for non-colorant arrays. fixes #10 #11

Evizero merged 1 commit into from
Apr 21, 2017

Conversation

@Evizero
Copy link
Member

@Evizero Evizero commented Apr 21, 2017

No description provided.

@Evizero Evizero mentioned this pull request Apr 21, 2017
Closed
@timholy
Copy link
Member

timholy commented Apr 21, 2017

ImageView supports numbers as well as Colorants, but that's because it's always called explicitly rather than implicitly.

@Evizero
Copy link
Member Author

Evizero commented Apr 21, 2017 •
edited
Loading

We could think about doing so for ImageInTerminal as well at some point, but that does require some non-trivial changes to https://github.com/JuliaImages/ImageInTerminal.jl/blob/master/src/colorant2ansi.jl. Though it does look simple enough if we can trust that the numbers are in the interval [0,1]

@Evizero Evizero merged commit bc696f5 into master Apr 21, 2017
@Evizero Evizero deleted the imshow branch April 21, 2017 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Evizero @timholy