Replace addunit by aslen for improved readability #1263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
Benchmark Results (Julia v1)Time benchmarks
Memory benchmarks
|
Contributor
Benchmark Results (Julia vlts)Time benchmarks
Memory benchmarks
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the unit handling system by replacing the addunit function with more focused aslen and aslentype functions. The changes improve clarity and consistency in how length units are added to dimensionless numbers throughout the codebase.
- Replaces
addunit(x, u"m")withaslen(x)for adding meter units to numbers - Replaces
addunit(x, u"m")withaslen.(x)for collections/tuples - Updates
aslentypefunction with simplified error message
Reviewed Changes
Copilot reviewed 26 out of 26 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/units.jl | Refactored addunit into aslen and aslentype functions with clearer naming and simplified error messages |
| src/vectors.jl | Updated Vec constructor to use aslen instead of addunit |
| src/transforms/*.jl | Updated transform constructors to use aslen |
| src/simplification/*.jl | Updated simplification method constructors to use aslen |
| src/sampling/*.jl | Updated sampling method constructors to use aslen |
| src/partitioning/*.jl | Updated partitioning method constructors to use aslen |
| src/neighborhoods/metricball.jl | Updated MetricBall constructors to use aslen |
| src/geometries/primitives/*.jl | Updated primitive geometry constructors to use aslen |
| src/domains/trajecs.jl | Updated trajectory constructors to use aslen |
| src/discretization/maxlength.jl | Updated discretization method constructors to use aslen |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1263 +/- ##
==========================================
- Coverage 87.90% 87.90% -0.01%
==========================================
Files 197 197
Lines 6241 6240 -1
==========================================
- Hits 5486 5485 -1
Misses 755 755 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor refactor to clean things up before further work.