Skip to content

Conversation

@juliohm
Copy link
Member

@juliohm juliohm commented Aug 22, 2025

Tweaks to use the public api of primitives when available.

@juliohm juliohm requested a review from mikeingold August 22, 2025 12:23
@github-actions
Copy link
Contributor

Benchmark Results (Julia v1)

Time benchmarks
master dcab049... master / dcab049...
clipping/SutherlandHodgman 3.33 ± 0.18 μs 3.31 ± 0.19 μs 1.01 ± 0.079
discretization/simplexify 25.1 ± 2.5 ms 25 ± 2.7 ms 1 ± 0.15
intersection/ray-triangle 0.06 ± 0 μs 0.06 ± 0 μs 1 ± 0
sideof/ring/large 6.83 ± 0.01 μs 6.84 ± 0.02 μs 0.999 ± 0.0033
sideof/ring/small 0.06 ± 0.009 μs 0.06 ± 0 μs 1 ± 0.15
topology/half-edge 2.72 ± 0.074 ms 2.75 ± 0.26 ms 0.989 ± 0.096
winding/mesh 0.0411 ± 0.0017 s 0.0413 ± 0.0017 s 0.995 ± 0.059
time_to_load 1.44 ± 0.0003 s 1.45 ± 0.0049 s 0.996 ± 0.0033
Memory benchmarks
master dcab049... master / dcab049...
clipping/SutherlandHodgman 0.053 k allocs: 4.83 kB 0.053 k allocs: 4.83 kB 1
discretization/simplexify 0.324 M allocs: 21.8 MB 0.324 M allocs: 21.8 MB 1
intersection/ray-triangle 0 allocs: 0 B 0 allocs: 0 B
sideof/ring/large 0 allocs: 0 B 0 allocs: 0 B
sideof/ring/small 0 allocs: 0 B 0 allocs: 0 B
topology/half-edge 20.8 k allocs: 2.92 MB 20.8 k allocs: 2.92 MB 1
winding/mesh 0.329 M allocs: 22.9 MB 0.329 M allocs: 22.9 MB 1
time_to_load 0.159 k allocs: 11.2 kB 0.159 k allocs: 11.2 kB 1

@codecov
Copy link

codecov bot commented Aug 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.86%. Comparing base (fb1c11e) to head (dcab049).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1248      +/-   ##
==========================================
- Coverage   87.86%   87.86%   -0.01%     
==========================================
  Files         196      196              
  Lines        6182     6181       -1     
==========================================
- Hits         5432     5431       -1     
  Misses        750      750              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

Benchmark Results (Julia vlts)

Time benchmarks
master dcab049... master / dcab049...
clipping/SutherlandHodgman 3.73 ± 0.23 μs 3.74 ± 0.27 μs 0.997 ± 0.095
discretization/simplexify 26.8 ± 1.6 ms 27.4 ± 1.6 ms 0.98 ± 0.08
intersection/ray-triangle 0.051 ± 0.01 μs 0.05 ± 0.001 μs 1.02 ± 0.2
sideof/ring/large 6.53 ± 0.01 μs 6.53 ± 0.01 μs 1 ± 0.0022
sideof/ring/small 0.05 ± 0.001 μs 0.05 ± 0.001 μs 1 ± 0.028
topology/half-edge 2.68 ± 0.031 ms 2.7 ± 0.027 ms 0.992 ± 0.015
winding/mesh 0.0425 ± 0.002 s 0.0429 ± 0.0018 s 0.992 ± 0.063
time_to_load 1.48 ± 0.014 s 1.47 ± 0.0043 s 1 ± 0.0097
Memory benchmarks
master dcab049... master / dcab049...
clipping/SutherlandHodgman 0.053 k allocs: 4.97 kB 0.053 k allocs: 4.97 kB 1
discretization/simplexify 0.226 M allocs: 21.8 MB 0.226 M allocs: 21.8 MB 1
intersection/ray-triangle 0 allocs: 0 B 0 allocs: 0 B
sideof/ring/large 0 allocs: 0 B 0 allocs: 0 B
sideof/ring/small 0 allocs: 0 B 0 allocs: 0 B
topology/half-edge 18.1 k allocs: 2.92 MB 18.1 k allocs: 2.92 MB 1
winding/mesh 0.231 M allocs: 23 MB 0.231 M allocs: 23 MB 1
time_to_load 0.153 k allocs: 14.5 kB 0.153 k allocs: 14.5 kB 1

@juliohm juliohm merged commit 7805c93 into master Aug 23, 2025
18 checks passed
@juliohm juliohm deleted the tweaks-primitives branch August 23, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants