Fix Transformation from ProjString by auto-adding +type=crs#124
Open
asinghvi17 wants to merge 2 commits intomainfrom
Open
Fix Transformation from ProjString by auto-adding +type=crs#124asinghvi17 wants to merge 2 commits intomainfrom
asinghvi17 wants to merge 2 commits intomainfrom
Conversation
Fixes #102 by automatically appending +type=crs to ProjString objects when creating a CRS. Without this parameter, proj_create() creates a projection object instead of a CRS object, causing Transformation to fail with "source_crs is not a CRS". The fix ensures ProjString works consistently with plain strings when used in Transformation and other CRS operations. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Tests verify that ProjString objects work identically to plain strings when used in Transformation. Includes test cases for: - Original issue #102 example (aeqd projection) - Simple longlat projection - ProjString with +type=crs already present - Both source and target as ProjString All tests verify that the same transformation pipeline is created regardless of whether String or ProjString is used. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #102 by automatically appending +type=crs to ProjString objects when creating a CRS. Without this parameter, proj_create() creates a projection object instead of a CRS object, causing Transformation to fail with "source_crs is not a CRS".
The fix ensures ProjString works consistently with plain strings when used in Transformation and other CRS operations.
🤖 Generated with Claude Code
Human reviewed, seems reasonable to me and a small change.