Skip to content

Conversation

@devmotion
Copy link
Member

@devmotion devmotion commented Jun 3, 2021

This PR separates the tests of Turing + Soss a bit more and fixes #161. I moved them to a separate action such that CI tests are still shown as passing, also in the README, if the Turing + Soss tests fail 🙂

I also thought it's sufficient to run the PPL tests with the stable Julia version on Linux.

@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2021

Codecov Report

Merging #162 (b6e4c33) into master (5bdd823) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #162      +/-   ##
==========================================
- Coverage   99.23%   99.23%   -0.01%     
==========================================
  Files          10        9       -1     
  Lines         262      260       -2     
==========================================
- Hits          260      258       -2     
  Misses          2        2              
Impacted Files Coverage Δ
src/abstract_gp/finite_gp.jl 100.00% <0.00%> (ø)
src/AbstractGPs.jl

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bdd823...b6e4c33. Read the comment docs.

Copy link
Member

@willtebbutt willtebbutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Please feel free to merge when CI passes.

@devmotion devmotion merged commit c4a32f1 into master Jun 3, 2021
@devmotion devmotion deleted the dw/ppl branch June 3, 2021 21:46
@devmotion
Copy link
Member Author

BTW tests with Julia nightlies are broken since isgenerated was renamed to hasgenerator on the master branch but IRTools uses isgenerated. It seems it would be fixed by FluxML/IRTools.jl#86 (or by reverting the change in base or at least re-adding isgenerated, there's some discussion in the original PR it seems).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Updating Dependencies

4 participants