-
Notifications
You must be signed in to change notification settings - Fork 31
Reduce number of mul! methods
#318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This requires the GPUArrays.jl PR to be merged and released first. |
|
Thanks for the PR! Note to self, we should also do this to Metal.jl (https://github.com/JuliaGPU/Metal.jl/blob/main/lib/mps/linalg.jl). I guess the change would be mostly similar.
We commit a Manifest here, so you can actually point it to your GPUArrays branch (or GPUArrays#master, once that PR would be merged). |
|
I couldn't find a |
lib/mkl/linalg.jl
Outdated
| # BLAS 2 | ||
| # | ||
|
|
||
| # TODO: Should there be a LinearAlgebra._generic_matvecmul! that dispatches to gemv!, symv! and hemv! ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder...
|
Same difference in ArgumentError as with the CUDA.jl PR.
Yeah that looks like an oversight. oneMKL has EDIT: actually, |
075c280 to
0e05610
Compare
Cf. JuliaGPU/GPUArrays.jl#472 and JuliaGPU/CUDA.jl#1904. Same here: if
gemm_dispatch!is (sufficiently) internal, it might be actually removed.