CI: Build PoCL without hwloc. #367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems optional, and for some reason results in compilation errors only on CI.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #367 +/- ##
=======================================
Coverage 78.86% 78.86%
=======================================
Files 12 12
Lines 672 672
=======================================
Hits 530 530
Misses 142 142 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vchuravy
approved these changes
Sep 10, 2025
simeonschaub
approved these changes
Sep 10, 2025
Member
simeonschaub
left a comment
simeonschaub
left a comment
There was a problem hiding this comment.
Looks like upstream just installed hwloc as a system dependency: https://github.com/pocl/pocl/pull/2009/files#diff-051785d6cced019c8995c0fa9e029390a2d600e46dca44145ad77e053cb95eb7R71
I guess we don't really need that functionality though, so this seems fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems optional, and for some reason results in compilation errors only on CI.
Addresses part of #366