Skip to content

Conversation

@vchuravy
Copy link
Member

No description provided.

@vchuravy vchuravy requested review from maleadt and pxl-th April 30, 2023 19:59
maleadt
maleadt previously approved these changes May 2, 2023
Copy link
Member

@maleadt maleadt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

using Pkg
Pkg.test("oneAPI"; coverage=true, test_args=["kernelabstractions"])'
agents:
queue: "juliaecosystem"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oneAPI runners aren't on the juliaecosystem queue yet, but on the juliagpu one.

@maleadt maleadt dismissed their stale review May 2, 2023 10:46

Didn't notice an issue.

@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.90 🎉

Comparison is base (a07ec99) 87.56% compared to head (d4ffcdf) 88.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #391      +/-   ##
==========================================
+ Coverage   87.56%   88.47%   +0.90%     
==========================================
  Files           8        8              
  Lines         539      772     +233     
==========================================
+ Hits          472      683     +211     
- Misses         67       89      +22     

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vchuravy vchuravy merged commit f7d7013 into main May 2, 2023
@vchuravy vchuravy deleted the vc/ka_reverse_ci branch May 2, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants