Add unsafe_free! #381
Merged
Add unsafe_free! #381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #381 +/- ##
==========================================
- Coverage 88.90% 88.88% -0.03%
==========================================
Files 8 8
Lines 541 540 -1
==========================================
- Hits 481 480 -1
Misses 60 60
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
vchuravy
reviewed
Apr 10, 2023
src/KernelAbstractions.jl
Outdated
| when an array goes out of scope, but can be called | ||
| earlier to reduce pressure on the memory allocator. | ||
| On CPU backend this is a no-op. |
Member
There was a problem hiding this comment.
Maybe reword this without the reference to the finalizer, since this method in particular will not be used.
Note that implementing it is optional (not only on the CPU) and what the contract is for the user.
pxl-th
force-pushed
the
pxl-th/unsafe-free
branch
from
8aa7fd5 to
c849af3
Compare
pxl-th
force-pushed
the
pxl-th/unsafe-free
branch
from
c849af3 to
0ce8a84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.