Add dwarf_version function so targets can choose #490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that targets can choose their own dwarf versions, (cuda needs v2)
Member
|
Great thank you! |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #490 +/- ##
==========================================
- Coverage 81.12% 73.29% -7.83%
==========================================
Files 23 23
Lines 3083 3048 -35
==========================================
- Hits 2501 2234 -267
- Misses 582 814 +232
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It defaults to 4 like before but PTX sets it to 2 because that's what cuda supports. Following https://github.com/search?q=repo%3Allvm%2Fllvm-project%20GetDefaultDwarfVersion()&type=code