Skip to content

adjust concrete_eval_eligible overload to v1.10 #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maleadt merged 1 commit into from
Aug 2, 2023
Merged

adjust concrete_eval_eligible overload to v1.10 #488

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion src/jlgen.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,25 @@ CC.method_table(interp::GPUInterpreter, sv::CC.InferenceState) = interp.method_t
end

# semi-concrete interepretation is broken with overlays (JuliaLang/julia#47349)
@static if VERSION >= v"1.9.0-DEV.1248"
@static if VERSION >= v"1.9.0-beta3"
function CC.concrete_eval_eligible(interp::GPUInterpreter,
@nospecialize(f), result::CC.MethodCallResult, arginfo::CC.ArgInfo, sv::CC.InferenceState)
# NOTE it's fine to skip overloading with `sv::IRInterpretationState` since we disables
# semi-concrete interpretation anyway.
ret = @invoke CC.concrete_eval_eligible(interp::CC.AbstractInterpreter,
f::Any, result::CC.MethodCallResult, arginfo::CC.ArgInfo, sv::CC.InferenceState)
@static if VERSION ≥ v"1.10.0-DEV.1345"
if ret === :semi_concrete_eval
return :none
end
else
if ret === false
return nothing
end
end
return ret
end
elseif VERSION >= v"1.9.0-DEV.1248"
function CC.concrete_eval_eligible(interp::GPUInterpreter,
@nospecialize(f), result::CC.MethodCallResult, arginfo::CC.ArgInfo)
ret = @invoke CC.concrete_eval_eligible(interp::CC.AbstractInterpreter,
Expand Down