use more precise isdefined check in linalg
#636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ran into issues when bisecting Julia, I think `isdefined` checks like these should generally be preferred over `VERSION` checks.
Member
|
I personally prefer accurate version checks because those are easier to get rid of when looking over the code at a later point (e.g. when we bump the minimum compat). Feature checks like this are likely to go unnoticed and remain present. If you don't know the exact cutoff, please add a comment indicating this is a v1.12 feature. |
simeonschaub
commented
Oct 14, 2025
Member
Author
simeonschaub
left a comment
simeonschaub
left a comment
There was a problem hiding this comment.
Ok, I added a comment mentioning this was added in 1.12. Tracking down the exact dev number has gotten a bit annoying now that LinearAlgebra has been moved into a separate repo
Co-authored-by: Simeon David Schaub <[email protected]>
maleadt
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into issues when bisecting Julia, I think
isdefinedchecks like these should generally be preferred overVERSIONchecks.