Skip to content

Fix tr in Julia 1.12 #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maleadt merged 6 commits into from
Oct 10, 2025
Merged

Fix tr in Julia 1.12 #633

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
489e099
Add `tr` function for `AbstractGPUMatrix`
mtfishman Oct 9, 2025
5ec9205
Add test for 'tr' function in linalg.jl
mtfishman Oct 9, 2025
46103c1
Fix call to LinearAlgebra.checksquare
mtfishman Oct 9, 2025
c0351a6
Generalize `tr` to AnyGPUMatrix
mtfishman Oct 9, 2025
6ee51c9
Format
mtfishman Oct 9, 2025
64b163b
Format
mtfishman Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/host/linalg.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,13 @@ function Base.copyto!(A::Array{T,N}, B::Transpose{T, <:AbstractGPUArray{T,N}}) w
copyto!(A, Transpose(Array(parent(B))))
end

## trace

function LinearAlgebra.tr(A::AnyGPUMatrix)
LinearAlgebra.checksquare(A)
sum(diag(A))
end

## copy upper triangle to lower and vice versa

function LinearAlgebra.copytri!(A::AbstractGPUMatrix, uplo::AbstractChar, conjugate::Bool=false)
Expand Down
3 changes: 3 additions & 0 deletions test/testsuite/linalg.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@
@test compare(transpose!, AT, Array{Float32}(undef, 128, 32), rand(Float32, 32, 128))
end

@testset "tr" begin
@test compare(tr, AT, rand(Float32, 32, 32))
end
@testset "permutedims" begin
@test compare(x -> permutedims(x, (2, 1)), AT, rand(Float32, 2, 3))
@test compare(x -> permutedims(x, (2, 1, 3)), AT, rand(Float32, 4, 5, 6))
Expand Down
Loading