Accomodate for rectangular matrices in copytrito! #538
+17
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkarrasch
approved these changes
May 30, 2024
Contributor
dkarrasch
left a comment
dkarrasch
left a comment
There was a problem hiding this comment.
Do you need tests for the failing cases?
amontoison
force-pushed
the
update_copytrito
branch
from
c1d2db5 to
4c9eb85
Compare
amontoison
force-pushed
the
update_copytrito
branch
from
4c9eb85 to
37d2f39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to JuliaLang/LinearAlgebra.jl#1074 and JuliaLang/julia#54587.
cc @dkarrasch