fix CI: add JLD2 dependency#823
Merged
luraess merged 1 commit intoJuliaGPU:masterfrom Sep 4, 2025
Merged
Conversation
Seems like AMDGPU.jl was forgotten :'( JuliaGPU/GPUArrays.jl#597 (comment)
Member
|
Thanks. Was unsure whether adding JLD2 deps to test was the way to go. But given this was done for other backends packages (as per JuliaGPU/GPUArrays.jl#597 (comment)), we may just do the same as well. |
Member
|
I am going to merge this PR given it fixes the JLD2 issue. The CI failure relates to cooperative groups support and is reported in #824 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems like AMDGPU.jl was forgotten :'( JuliaGPU/GPUArrays.jl#597 (comment)