Skip to content

Conversation

@lostella
Copy link
Member

@lostella lostella commented Apr 4, 2020

No description provided.

@lostella lostella changed the title set documenter version Set documenter version, bump Julia versions in CI Apr 4, 2020
@codecov-io
Copy link

codecov-io commented Apr 4, 2020

Codecov Report

Merging #32 into master will decrease coverage by 1.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
- Coverage   91.74%   90.46%   -1.29%     
==========================================
  Files          17       17              
  Lines         424      430       +6     
==========================================
  Hits          389      389              
- Misses         35       41       +6
Impacted Files Coverage Δ
src/arraypartition.jl 57.14% <0%> (-9.53%) ⬇️
src/syntax/variable.jl 81.81% <0%> (-8.19%) ⬇️
src/calculus/precomposeNonlinear.jl 86.95% <0%> (-3.96%) ⬇️
src/syntax/expressions/addition.jl 79.48% <0%> (-2.1%) ⬇️
src/syntax/terms/proximalOperators_bind.jl 88.13% <0%> (-1.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fabcb5b...7ea2fb0. Read the comment docs.

@lostella lostella requested a review from nantonel April 4, 2020 12:45
@lostella
Copy link
Member Author

lostella commented Apr 5, 2020

The docs build is likely broken because matrix supersedes jobs, see e.g. one of the blue boxes here https://juliadocs.github.io/Documenter.jl/stable/man/hosting/

I replaced both Travis and Appveyor with a GitHub workflow in ProximalOperators, see https://github.com/kul-forbes/ProximalOperators.jl/blob/master/.github/workflows/ci.yml, as soon as I get the docs build working on it I can do the same here: these workflows are faster at running checks, their configuration is likely more stable than Travis’, allow you to do all in one place (GitHub).

Will update this PR with that, if there are no concerns @nantonel

@lostella lostella force-pushed the set-documenter-compat branch from bf76fe8 to 959f878 Compare April 5, 2020 12:21
@lostella lostella changed the title Set documenter version, bump Julia versions in CI Set documenter version, switch to GitHub workflow for CI Apr 5, 2020
@lostella lostella merged commit d8d971d into JuliaFirstOrder:master Apr 5, 2020
@lostella lostella deleted the set-documenter-compat branch April 5, 2020 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants