Skip to content

Conversation

@lostella
Copy link
Member

@lostella lostella commented Jun 22, 2019

This PR refactors the algorithms API, by splitting an algorithm construction (with parameters and so on), and its application to a problem. E.g.:

algorithm = ForwardBackward(parameters...)
x, it = algorithm(f=f, A=A, g=g)

@nantonel: I will prepare a PR to StructuredOptimization.jl so we can check in parallel if this looks OK for that too.

@codecov-io
Copy link

codecov-io commented Jun 22, 2019

Codecov Report

Merging #22 into master will decrease coverage by 4.53%.
The diff coverage is 77.5%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #22      +/-   ##
=========================================
- Coverage   93.93%   89.4%   -4.54%     
=========================================
  Files          12      12              
  Lines         445     500      +55     
=========================================
+ Hits          418     447      +29     
- Misses         27      53      +26
Impacted Files Coverage Δ
src/utilities/iterationtools.jl 78.18% <40%> (-21.82%) ⬇️
src/algorithms/primaldual.jl 80.23% <81.81%> (-2.05%) ⬇️
src/algorithms/forwardbackward.jl 92.53% <82.35%> (-4.13%) ⬇️
src/algorithms/douglasrachford.jl 90.9% <84.61%> (-9.1%) ⬇️
src/algorithms/panoc.jl 93.61% <86.66%> (-1.89%) ⬇️
src/algorithms/zerofpr.jl 92.4% <86.66%> (-2.19%) ⬇️
src/algorithms/davisyin.jl 95.12% <88.88%> (-4.88%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0446f08...e8b6961. Read the comment docs.

@lostella lostella merged commit 3bb7528 into JuliaFirstOrder:master Jul 7, 2019
@lostella lostella deleted the solvers-constructors branch July 7, 2019 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants