Deprecation fixes #643
Deprecation fixes #643
Conversation
fredrikekre
force-pushed
the
fe/markdown
branch
from
717166d to
31044e5
Compare
mortenpi
left a comment
mortenpi
left a comment
There was a problem hiding this comment.
Looks great, thanks for doing this! Will merge once Compat is out and the tests pass.
| nameof(b::Base.Docs.Binding) = b.var | ||
| nameof(x::DataType) = x.name.name | ||
| nameof(m::Module) = module_name(m) | ||
| nameof(m::Module) = Compat.nameof(m) |
There was a problem hiding this comment.
I guess this could actually just extend the nameof in Base. But that is beyond this PR.
There was a problem hiding this comment.
Yeah, we should actually remove the nameof definitions here to avoid shadowing Base on 0.7.
There was a problem hiding this comment.
I did extend at first but that a bit weird. Either we leave it as is here, or upstream the other nameof methods to base. Not sure how useful the other methods are though, so I think its fine to leave this as is.
| find_object(::Union{Function, DataType}, binding, ::Union{Union,Type{Union{}}}) = Utilities.Object(binding, Union{}) | ||
| find_object(other, binding, typesig) = Utilities.Object(binding, typesig) | ||
|
|
||
| _method_exists(f, t) = method_exists(f, t) |
There was a problem hiding this comment.
Apparently this actually made sense back when Documenter still supported 0.4. Good to get rid of this. 😆
fredrikekre
force-pushed
the
fe/markdown
branch
from
31044e5 to
69acbff
Compare
fredrikekre
force-pushed
the
fe/markdown
branch
from
69acbff to
55dcbc2
Compare
|
The Windows failures on 0.7 are unrelated. (They've been happening everywhere.) It'll need an admin to merge since it's a required check. |
Requires JuliaLang/Compat.jl#492, JuliaLang/Compat.jl#493
and JuliaLang/Compat.jl#494and then a new Compat release to pass on 0.6.