Remove GitHub token build trigger warning #1517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortenpi
added
Type: Documentation
Type: Maintenance
and removed
Type: Enhancement
labels
Member
|
LGTM, I can also confirm that the pages builds seem to be triggered without any issues, so these warnings are no longer necessary. Thanks @knuesel! Although I think it's still worth emphasizing that the user probably needs to set up a |
mortenpi
pushed a commit
that referenced
this pull request
Feb 14, 2021
(cherry picked from commit 8d75805)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a warning from the documentation and from the CI output, saying that GitHub Page builds are not triggered when using a GitHub token for authentication.
As discussed in #1177, the build trigger seems to be fixed now. I tested the following scenarios:
These tests were made without pushing a commit manually to the
gh-pages. The Pages build was correctly triggered in all cases.Note that there is still a warning in the documentation for tags created with GitHub tokens (e.g. by TagBot).
Closes #1177