Rename loop variable to avoid conflict #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I think Travis is still recovering from a major outage, so it may be a while before the macOS builds even start... |
Member
|
Yup, not a problem. Linux builds pass without issues. Will merge and tag. Thanks! |
mortenpi
pushed a commit
that referenced
this pull request
Jan 18, 2018
(cherry picked from commit 739f356)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JuliaLang/julia#25622 introduces a new function called
namethat replacesmodule_nameand a couple other things. This package is usingnameas a loop variable and comparing that against the result of (what will be) a call to thenamefunction, which results in an error when building documentation. This PR simply renames the loop variable to avoid this conflict.It would be great if we could get this in ASAP, since it's blocking the Base PR.