Conversation
gdalle
changed the title
cat tests as broken for > 3 arguments
devmotion
left a comment
devmotion
left a comment
There was a problem hiding this comment.
While I appreciate "fixing" CI, I think this PR (and others merged recently) should have been reviewed.
| @test x isa type | ||
| @test value(x) == f(args...; kwargs...) | ||
| broken = f == hcat && (args[2] isa AbstractMatrix) | ||
| if broken && VERSION >= v"1.4" |
There was a problem hiding this comment.
Why 1.4? AFAICT (and as mentioned eg in #259) this issue is caused by a type piracy in SparseArrays introduced in Julia 1.10 (see JuliaSparse/SparseArrays.jl#431).
There was a problem hiding this comment.
I didn't do the bisection to figure out which version of Julia was guilty. I just took the version that was above 1.3, on which I was sure the tests were passing. I can replace it with 1.10, no problem.
Tbh we should just drop 1.0 and 1.3, even Julia doesn't support those anymore
That's true, but the last issue I opened, outlining a genuine bug (#251) got zero answer in four months. I was unsure if anyone was actually watching or interested. |
|
Another reason why this PR was necessary is that for lack of a |
2 participants
@testsetcattests as brokenAt the moment,
testcatinArrayFunctionTests.jlis broken for 4 or more arguments because of a method ambiguity (see #242). This PR doesn't fix the source of the problem, it just ignores broken tests so that CI passes. To be fair, these tests are not very useful.These broken tests pass on Julia 1.0 and 1.3 (for which support should be dropped anyway) but fail on 1.10. At some point between the two, a type piracy appeared in SparseArrays which caused the ambiguity.