Skip to content

prevent adding methods to the functions > and >= #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devmotion merged 2 commits into from
Sep 8, 2025
Merged

prevent adding methods to the functions > and >= #771

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a7fc05
prevent adding methods to the functions `>` and `>=`
nsajko Sep 8, 2025
15f0d80
remove `eval` and `for`
nsajko Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/dual.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,7 @@ end
# Before PR#481 this loop ran over this list:
# BINARY_PREDICATES = Symbol[:isequal, :isless, :<, :>, :(==), :(!=), :(<=), :(>=)]
# Not a minimal set, as Base defines some in terms of others.
for pred in [:<, :>]
for pred in [:<]
Copy link
Member

@devmotion devmotion Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With only a single element in pred, the loop and the @eval below are not needed anymore. Can you remove them?

predeq = Symbol(pred, :(=))
@eval begin
@define_binary_dual_op(
Expand Down
Loading