refactor: move SparseArrays into an extension#192
Merged
ChrisRackauckas merged 1 commit intoJuliaDiff:masterfrom Oct 5, 2024
Merged
refactor: move SparseArrays into an extension#192ChrisRackauckas merged 1 commit intoJuliaDiff:masterfrom
SparseArrays into an extension#192ChrisRackauckas merged 1 commit intoJuliaDiff:masterfrom
Conversation
gdalle
reviewed
Oct 4, 2024
Member
gdalle
left a comment
gdalle
left a comment
There was a problem hiding this comment.
LGTM, although I only superficially checked the copypaste. Might be good to improve coverage though, there are few critical lines that are never hit
Member
|
All of the ODE downstream tests are having an issue with it? https://github.com/JuliaDiff/FiniteDiff.jl/actions/runs/11186924624/job/31102969796?pr=192#step:6:1601 |
Contributor
Author
Those are failing without this patch also https://github.com/SciML/NonlinearSolve.jl/actions/runs/11184646088/job/31095855785#step:6:1592 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @gdalle @ChrisRackauckas (cannot tag reviewers)