Skip to content

fix mod CI test #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devmotion merged 2 commits into from
Dec 11, 2021
Merged

fix mod CI test #78

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94d3353
fix mod CI test
Dec 11, 2021
f9d70df
devmotion suggestion
Dec 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ end
@testset "DiffRules" begin
@testset "check rules" begin

non_numeric_arg_functions = [(:Base, :rem2pi, 2), (:Base, :ifelse, 3)]
non_numeric_arg_functions = [(:Base, :rem2pi, 2), (:Base, :ifelse, 3), (:Base, :mod, 2)]

for (M, f, arity) in DiffRules.diffrules(; filter_modules=nothing)
(M, f, arity) ∈ non_numeric_arg_functions && continue
Expand Down Expand Up @@ -91,6 +91,18 @@ for xtype in [:Float64, :BigFloat, :Int64]
end
end
end

# Treat mod separately because of discontinuities at integers
derivs = DiffRules.diffrule(:Base, :mod, :x, :y)
@eval begin
let
x = randn()
y = randn()
dx, dy = $(derivs[1]), $(derivs[2])
@test isapprox(dx, finitediff(z -> mod(z, y), float(x)), rtol=0.05)
@test isapprox(dy, finitediff(z -> mod(x, z), float(y)), rtol=0.05)
end
end
end

@testset "diffrules" begin
Expand Down