Skip to content

Conversation

@mzgubic
Copy link
Member

@mzgubic mzgubic commented Feb 17, 2022

Closes #538

@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2022

Codecov Report

Merging #541 (ed372aa) into main (3e11e62) will decrease coverage by 6.65%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #541      +/-   ##
==========================================
- Coverage   93.41%   86.75%   -6.66%     
==========================================
  Files          15       14       -1     
  Lines         865      687     -178     
==========================================
- Hits          808      596     -212     
- Misses         57       91      +34     
Impacted Files Coverage Δ
src/projection.jl 88.55% <100.00%> (-8.75%) ⬇️
src/config.jl 0.00% <0.00%> (-100.00%) ⬇️
src/ignore_derivatives.jl 50.00% <0.00%> (-25.00%) ⬇️
src/tangent_types/tangent.jl 71.29% <0.00%> (-14.22%) ⬇️
src/tangent_types/thunks.jl 86.04% <0.00%> (-9.41%) ⬇️
src/tangent_types/abstract_zero.jl 90.47% <0.00%> (-4.98%) ⬇️
src/accumulation.jl 92.85% <0.00%> (-4.37%) ⬇️
src/rule_definition_tools.jl 93.27% <0.00%> (-3.00%) ⬇️
src/rules.jl 88.88% <0.00%> (-2.03%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e11e62...ed372aa. Read the comment docs.

@mzgubic mzgubic requested a review from mcabbott February 17, 2022 16:54
@mcabbott
Copy link
Member

This is fine by me. But I think @oxinabox objected to this the first time around.

Co-authored-by: Frames Catherine White <[email protected]>
@mzgubic mzgubic merged commit 3394de6 into main Feb 18, 2022
@mzgubic mzgubic deleted the mz/project_inplaceablethunk branch February 18, 2022 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(::ProjectTo)(:: InplaceableThunk)

5 participants