Skip to content

backport #571 #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mzgubic merged 1 commit into from
Feb 28, 2022
Merged

backport #571 #593

mzgubic merged 1 commit into from
Feb 28, 2022

Conversation

@mzgubic
Copy link
Member

@mzgubic mzgubic commented Feb 24, 2022

@github-actions github-actions bot added the needs version bump Version needs to be incremented or set to -DEV in Project.toml label Feb 24, 2022
@mzgubic
Copy link
Member Author

mzgubic commented Feb 24, 2022

the ReversePropagation error exists on master and seems unrelated.

@mzgubic mzgubic requested a review from mcabbott February 25, 2022 12:20
mcabbott
mcabbott approved these changes Feb 28, 2022
View reviewed changes
Copy link
Member

@mcabbott mcabbott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me.

Is backport-1.21 the right branch name? If there may be other things backported, perhaps the same branch should end up with several tags, in which case something like julia1.0 not mentioning a version might be better?

@devmotion
Copy link
Member

devmotion commented Feb 28, 2022

Is backport-1.21 the right branch name? If there may be other things backported, perhaps the same branch should end up with several tags, in which case something like julia1.0 not mentioning a version might be better?

But if you backport anything to this branch, you can only release it as 1.21.x, can't you? So backport-1.21 seems reasonable IMO.

@mzgubic mzgubic merged commit be1f6eb into backport-1.21 Feb 28, 2022
@mzgubic mzgubic deleted the mz/uniformscaling branch February 28, 2022 10:13
@mcabbott
Copy link
Member

mcabbott commented Feb 28, 2022

Oh sorry, somehow I thought there was one more dot in that version number. 1.21 is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcabbott mcabbott mcabbott approved these changes

Assignees

No one assigned

Labels

needs version bump Version needs to be incremented or set to -DEV in Project.toml

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mzgubic @devmotion @mcabbott