Drop support for Julia 1.0 #577
Conversation
test/Project.toml
Outdated
| Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40" | ||
|
|
||
| [compat] | ||
| ChainRulesCore = "1.11.5" |
There was a problem hiding this comment.
Does test/Project.toml need to contain full-time deps again, or are they implied?
There was a problem hiding this comment.
They are implied but I would rather not use the test/Project.toml.
It is annoying to keep these things in sync when things move from test only to main dep.
There was a problem hiding this comment.
I don't mind, should have left it a separate commit... you can fight it out with Seth?
There was a problem hiding this comment.
Let's not fight. Simplest to leave it as is then. (I like the convenience of activating the test directory in the REPL while testing stuff)
There was a problem hiding this comment.
Seth, this might be of interest: https://github.com/JuliaTesting/TestEnv.jl
oxinabox
left a comment
oxinabox
left a comment
There was a problem hiding this comment.
Thanks!
I assume you have done a findinfiles VERSION search.
Approved.
subject to reunifying back down to 1 Project.toml.
mcabbott
force-pushed
the
lts16
branch
2 times, most recently
from
fba4e14 to
9939444
Compare
Oh no, I guess I searched only
|
4 participants
Closes #574