Add repeat frules and tests #406
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Miha Zgubic <[email protected]>
Co-authored-by: Miha Zgubic <[email protected]>
Co-authored-by: Miha Zgubic <[email protected]>
Co-authored-by: Miha Zgubic <[email protected]>
Co-authored-by: Miha Zgubic <[email protected]>
mcabbott
reviewed
Jul 3, 2021
Comment on lines
+144
to
+154
| function frule((_, Δx), ::typeof(repeat), x, m::Integer) | ||
| return repeat(x, m), repeat(Δx, m) | ||
| end | ||
|
|
||
| function frule((_, Δxs), ::typeof(repeat), xs; inner=ntuple(_->1, ndims(xs)), outer=ntuple(_->1, ndims(xs))) | ||
| return repeat(xs; inner=inner, outer=outer), repeat(Δxs; inner=inner, outer=outer) | ||
| end | ||
|
|
||
| function frule((_, Δx), ::typeof(repeat), x::AbstractArray{<:Real,0}, m::Integer) | ||
| return repeat(x, m), repeat(fill(Δx,m)) | ||
| end |
Member
There was a problem hiding this comment.
These are the rules not covered by #460, which only did rrules. PR could be rebased to still add these.
Author
There was a problem hiding this comment.
I will take a look at this around Wednesday this week after finishing my late JuliaCon vid. Sorry I lost track of them
Member
There was a problem hiding this comment.
No rush, was just closing stale PRs & thought this one should get a note for whenever someone looks.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully I did this right, git-fu is WIP. This is based on PR #405, don't think I did that right... Are dependent PRs possible in GitHub?