Restore trackedheads
#126
Merged
Restore trackedheads
#126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes timholy/Revise.jl#906 - removes a compilation warning about conflict in SSAValue and SlotNumber. - improves handling of `setglobal!`
Merged
aviatesk
reviewed
Apr 19, 2025
Member
aviatesk
left a comment
aviatesk
left a comment
There was a problem hiding this comment.
I was planning to update the Revise side with updating LCU compat, but would it be better to make the changes here instead?
Member
Author
|
On the Revise side we'd technically need to use https://github.com/JuliaRegistries/RetroCap.jl to prevent previous Revise releases from being used in conjunction with LCU 3.2. It seems easier to first push a deprecation here and then prepare Revise for the new approach? |
Member
|
Got it. I've already implemented the changes on the Revise side, so I'll take care of it. |
aviatesk
approved these changes
Apr 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SlotNumber.
setglobal!