Fix for change in CodeInfo.slotnames type on julia master #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #251 +/- ##
=======================================
Coverage 87.15% 87.15%
=======================================
Files 14 14
Lines 1985 1985
=======================================
Hits 1730 1730
Misses 255 255
Continue to review full report at Codecov.
|
Member
|
Add a TODO to remove this completely after support for 1.1 is dropped? |
Member
Author
That'd be fine, but are we expecting to need to drop support for any Julia 1.x versions? So far I think it's not been hard to keep supporting them all. |
Member
|
Probably not. The comment might just be distracting. Fine either way :) |
timholy
added a commit
that referenced
this pull request
Apr 2, 2019
Merged
timholy
added a commit
that referenced
this pull request
Apr 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trivial, but I suspect we may want to tag 0.4.1 fairly soon.