more control over optimized debuginfo#151
Conversation
This introduces three levels of debuginfo: `none`, `compact`, which is equivalent to `source` for unoptimized code, but for optimized code gives the same compact lineinfo printing as in previous Cthulhu versions, and `source` which now always uses the same printing. depends on JuliaLang/julia#40459 closes #149, closes #150
simeonschaub
force-pushed
the
sds/ircode_printing
branch
from
1b2f58d to
17e3721
Compare
|
Just needs the nightliy builds to propagate through. |
| ## | ||
| function _descend(interp::CthulhuInterpreter, mi::MethodInstance; override::Union{Nothing, InferenceResult} = nothing, iswarn::Bool, params=current_params(), optimize::Bool=true, interruptexc::Bool=true, verbose=true, kwargs...) | ||
| debuginfo = true | ||
| debuginfo = 1 # default is compact debuginfo |
There was a problem hiding this comment.
Any specific reason to not use 1-based index here ?
There was a problem hiding this comment.
Not really. Using 0 for no debuginfo felt a little more natural, but I can also just change it to use one based indexing.
There was a problem hiding this comment.
imho something like debuginfo_keys[debuginfo + 1] looks a bit verbose, but I'm okay with either way. Your choice :)
There was a problem hiding this comment.
The right thing to do is to use enums ;)
There was a problem hiding this comment.
Does this look like a reasonable compromise?
Co-authored-by: Shuhei Kadowaki <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #151 +/- ##
=========================================
Coverage ? 44.64%
=========================================
Files ? 7
Lines ? 887
Branches ? 0
=========================================
Hits ? 396
Misses ? 491
Partials ? 0
Continue to review full report at Codecov.
|
simeonschaub
changed the title
|
OK if I merge this like this? This is currently preventing Cthulhu from working on Julia nightly. |
This was accidentally broken by #151.
4 participants
This introduces three levels of debuginfo:
none,compact, which isequivalent to
sourcefor unoptimized code, but for optimized codegives the same compact lineinfo printing as in previous Cthulhu
versions, and
sourcewhich now always uses the same printing.depends on JuliaLang/julia#40459
closes #149, closes #150