Annotate merge-base comparisons; improve report links#226
Annotate merge-base comparisons; improve report links#226IanButterworth wants to merge 1 commit into
Conversation
|
We are using the merge base, but only when |
|
Ah ok. I remember that now. I think the current common |
73663a9 to
e0b3948
Compare
|
Updated to just improve user guidance |
e0b3948 to
b74bcf3
Compare
Add transparency around merge-base comparisons (introduced in #134): reports and reply comments now indicate when a merge-base was used and show which branch it was computed from. When `vs` explicitly references the PR's base branch (e.g. `vs=":master"` on a PR targeting master), add a hint suggesting to omit `vs` to get the merge-base comparison. Also: - Show SHA range in Comparison Diff/Range links instead of generic "link" - Remove unused `prnumber` parameter from `build_julia!` - Remove stale comments about merge commit building (never implemented) - Simplify `build_benchmarksjulia!` call site Co-Authored-By: Claude <noreply@anthropic.com>
b74bcf3 to
2431578
Compare
|
The recommendation should just be to do |
|
Yeah, I'm just seeing a lot of use of This just tries to make it clearer. |
|
With |
|
Ah I see. |
Comments in the code indicated we use the merge base, but it doesn't actually seem we do.Actually, it's just a footgun of using the
vs=:masterform when you just want a PR diff. Adds user guidnace.Developed with claude:
Updated
Add transparency around merge-base comparisons (introduced in #134):
reports and reply comments now indicate when a merge-base was used and
show which branch it was computed from. When
vsexplicitly referencesthe PR's base branch (e.g.
vs=":master"on a PR targeting master),add a hint suggesting to omit
vsto get the merge-base comparison.Also:
prnumberparameter frombuild_julia!build_benchmarksjulia!call site