Make Cholesky factorization compatible with 0.7 #398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that the error handling is still a bit different as `_chol!` still throws an error instead of returning a non-zero `info`.
Codecov Report
@@ Coverage Diff @@
## master #398 +/- ##
==========================================
- Coverage 92.42% 92.36% -0.07%
==========================================
Files 37 37
Lines 2813 2816 +3
==========================================
+ Hits 2600 2601 +1
- Misses 213 215 +2
Continue to review full report at Codecov.
|
kshyatt
approved these changes
May 27, 2018
Collaborator
kshyatt
left a comment
kshyatt
left a comment
There was a problem hiding this comment.
LGTM, the CI "fail" is in Coverage
andyferris
approved these changes
May 27, 2018
Member
|
I believe Matt Baumann is currently destroying everything so we'll be revisiting this shortly :laugh: |
Collaborator
Author
|
Hehe, I had planned to bump this today, remarking it would probably be due for an overhaul after JuliaLang/julia#27249. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the error handling is still a bit different as
_chol!still throws an error instead of returning a non-zeroinfo.