Skip to content

Conversation

@timholy
Copy link
Member

@timholy timholy commented Feb 21, 2021

This displays both the values and indexes of an IdOffsetRange:

julia> using OffsetArrays: IdOffsetRange

julia> IdOffsetRange(11:13, -2)
IdOffsetRange(values=9:11, indexes=-1:1)

It also adds a constructor so that this is round-trippable:

julia> IdOffsetRange(values=9:11, indexes=-1:1)
IdOffsetRange(values=9:11, indexes=-1:1)

Closes #179
Closes #193

@codecov
Copy link

codecov bot commented Feb 21, 2021

Codecov Report

Merging #208 (c381843) into master (fe95c00) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #208      +/-   ##
==========================================
+ Coverage   98.31%   98.33%   +0.02%     
==========================================
  Files           5        5              
  Lines         297      301       +4     
==========================================
+ Hits          292      296       +4     
  Misses          5        5              
Impacted Files Coverage Δ
src/axes.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe95c00...c381843. Read the comment docs.

@jishnub
Copy link
Member

jishnub commented Feb 21, 2021

I like this. Perhaps we should use 'indices' instead of 'indexes' to be consistent with the array summary convention?

@timholy
Copy link
Member Author

timholy commented Feb 26, 2021

There are some fixes that should probably go into 1.6.x, but once we start thinking about a 1.7 (or 2.0) release I would plan to merge this.

@timholy
Copy link
Member Author

timholy commented Mar 4, 2021

Have all bugfix PRs been merged? If so let's start on the next minor release.

@jishnub
Copy link
Member

jishnub commented Mar 4, 2021

Yes the other PRs are for the 1.7 series

@timholy timholy force-pushed the teh/show_roundtrip branch from 3524455 to c381843 Compare March 4, 2021 13:45
@timholy timholy merged commit ac9821e into master Mar 4, 2021
@timholy timholy deleted the teh/show_roundtrip branch March 4, 2021 13:57
@timholy
Copy link
Member Author

timholy commented Mar 4, 2021

Looking forward to easier debugging already...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants