Skip to content

fix show for OffsetRanges #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jishnub merged 2 commits into from
Feb 11, 2021
Merged

fix show for OffsetRanges #200

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
524f76e
fix show for OffsetRanges
jishnub Feb 9, 2021
837b6d4
Do not show type
jishnub Feb 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/OffsetArrays.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,8 +368,7 @@ indexing is faster with ranges =#

function Base.show(io::IO, r::OffsetRange)
show(io, r.parent)
o = r.offsets[1]
print(io, " with indices ", o+1:o+length(r))
print(io, " with indices ", UnitRange(axes(r, 1)))
end
Base.show(io::IO, ::MIME"text/plain", r::OffsetRange) = show(io, r)

Expand Down
6 changes: 6 additions & 0 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1003,6 +1003,12 @@ end
show(io, MIME"text/plain"(), OffsetArray(3:5, 0:2))
@test String(take!(io)) == "3:5 with indices 0:2"

# issue #198
r = axes(OffsetVector(1:10, -5), 1)
a = OffsetVector(r, 5)
show(io, a)
@test String(take!(io)) == "$(repr(r)) with indices $(UnitRange(axes(a,1)))"

d = Diagonal([1,2,3])
Base.print_array(io, d)
s1 = String(take!(io))
Expand Down