Skip to content

document OffsetVector and OffsetMatrix #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
johnnychen94 merged 2 commits into from
Sep 24, 2020
Merged

document OffsetVector and OffsetMatrix #160

johnnychen94 merged 2 commits into from
Sep 24, 2020

Conversation

@tpapp
Copy link
Contributor

@tpapp tpapp commented Sep 23, 2020

No description provided.

@tpapp tpapp changed the title Tp/document offsetvectormatrix document OffsetVector and OffsetMatrix Sep 23, 2020
johnnychen94
johnnychen94 approved these changes Sep 23, 2020
View reviewed changes
Copy link
Member

@johnnychen94 johnnychen94 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is actually an initialization version:

OffsetVector{T}(::Initializer, offset_range)

but since this is not documented in OffsetArray neither. I think it is okay to get this in.

@johnnychen94 johnnychen94 merged commit 1fb1716 into JuliaArrays:master Sep 24, 2020
@tpapp tpapp deleted the tp/document-offsetvectormatrix branch September 24, 2020 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnnychen94 johnnychen94 johnnychen94 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tpapp @johnnychen94