Skip to content

Conversation

@dlfivefifty
Copy link
Member

In BlockArrays getindex may call view, so this redesigns getindex and view to both call _fill_getindex and avoid possible overflows.

@codecov
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #141 (19b7e25) into master (0606a8c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #141   +/-   ##
=======================================
  Coverage   95.66%   95.66%           
=======================================
  Files           4        4           
  Lines         531      531           
=======================================
  Hits          508      508           
  Misses         23       23           
Impacted Files Coverage Δ
src/FillArrays.jl 94.27% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0606a8c...19b7e25. Read the comment docs.

@dlfivefifty dlfivefifty merged commit ee9bafd into master Mar 11, 2021
@dlfivefifty dlfivefifty deleted the dl/avoidstackoverflowinview branch March 11, 2021 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants