Skip to content

Conversation

@dlfivefifty
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 22, 2020

Codecov Report

Merging #122 into master will decrease coverage by 0.56%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #122      +/-   ##
==========================================
- Coverage   91.88%   91.32%   -0.57%     
==========================================
  Files           4        4              
  Lines         456      461       +5     
==========================================
+ Hits          419      421       +2     
- Misses         37       40       +3     
Impacted Files Coverage Δ
src/fillalgebra.jl 99.18% <ø> (-0.02%) ⬇️
src/fillbroadcast.jl 77.14% <83.33%> (+1.28%) ⬆️
src/FillArrays.jl 91.86% <100.00%> (-0.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1179e7d...dad545e. Read the comment docs.

@dlfivefifty
Copy link
Member Author

This is a breaking change as conceivably one might have done

a = Zeros(5,5)[:,1]
a[1] = 2

downstream, which no longer works because now a isa Zeros.

@dlfivefifty dlfivefifty merged commit d88461b into master Oct 23, 2020
@dlfivefifty dlfivefifty deleted the dl/broadcastplus branch October 23, 2020 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants