Use is_forwarding_wrapper trait instead of parent_type(T) <: T
#296
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the heuristic
parent_type(T) <: Tsometimes gives incorrect results and may hide holes in the interface (as I found when making these changes).Some problems I found:
is_increasing(stride_rank(A))didn't account forAhaving zero dimensionsis_dense(A)didn't know how to handle whendense_dims(A)returnednothing.contiguous_axis(::Type{<:ReshapedArray})would sometimes returnnothing(meaning the contiguous axis is unknown) instead ofStaticInt(-1)when we actually knew there couldn't be a contiguous axis because it didn't exist in the parent array.(known)_dimnames(A)was often returning incorrect results forReinterpretArrayandReshapedArray.