Skip to content

Conversation

@Tokazama
Copy link
Member

@Tokazama Tokazama commented Jun 1, 2022

Motivated by SciML/Static.jl#64.

@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

Merging #286 (34d46d2) into master (2d3b1e2) will increase coverage by 12.63%.
The diff coverage is 88.88%.

@@             Coverage Diff             @@
##           master     #286       +/-   ##
===========================================
+ Coverage   76.98%   89.61%   +12.63%     
===========================================
  Files           9        9               
  Lines        1299     1300        +1     
===========================================
+ Hits         1000     1165      +165     
+ Misses        299      135      -164     
Impacted Files Coverage Δ
src/indexing.jl 86.38% <50.00%> (+0.52%) ⬆️
src/ArrayInterface.jl 85.95% <80.00%> (+8.26%) ⬆️
src/dimensions.jl 97.14% <83.33%> (+5.05%) ⬆️
src/axes.jl 92.99% <100.00%> (+0.63%) ⬆️
src/ranges.jl 90.54% <100.00%> (ø)
src/size.jl 90.36% <100.00%> (+4.81%) ⬆️
src/stridelayout.jl 86.37% <100.00%> (+38.41%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d3b1e2...34d46d2. Read the comment docs.

@Tokazama Tokazama merged commit f67325d into master Jun 1, 2022
@Tokazama Tokazama deleted the pre-static-changes branch June 1, 2022 12:44
@chriselrod
Copy link
Collaborator

chriselrod commented Jun 3, 2022

Did you see

WARNING: Method definition promote_shape(Tuple{Vararg{Union{Int64, Static.StaticInt{N} where N}}}, Tuple{Vararg{Union{Int64, Static.StaticInt{N} where N}}}) in module Static at /home/chriselrod/.julia/dev/Static/src/Static.jl:274 overwritten in module ArrayInterface at /home/chriselrod/.julia/dev/ArrayInterface/src/dimensions.jl:16.
  ** incremental compilation may be fatally broken for this module **

I guess this will be moved when switching from Static 0.6 to Static 0.7?

@Tokazama
Copy link
Member Author

Tokazama commented Jun 3, 2022

That was the intention, since promote_shape doesn't require anything but StaticInt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants