fix ndims_index(::CartesianIndices{0}) + ndims_index tests #283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When indexing empty `CartesianIndices` uniquely map to trailiing dimensions that may be dropped. Therefore, we need to preserve them as an indicator of which dimension to drop.
Codecov Report
@@ Coverage Diff @@
## master #283 +/- ##
=======================================
Coverage 76.98% 76.98%
=======================================
Files 9 9
Lines 1299 1299
=======================================
Hits 1000 1000
Misses 299 299 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When indexing empty
CartesianIndicesuniquely map to trailiingdimensions that may be dropped. Therefore, we need to preserve them
as an indicator of which dimension to drop.