Move definition of Domain to DomainSetsCore.jl package #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
There are many other changes in this PR, related to treating domains as an interface rather than a type. For some explanation, see JuliaMath/IntervalSets.jl#136 (comment). These changes are likely to be breaking some things, so the version update should reflect that. |
This was referenced Aug 22, 2023
Member
Author
|
This is superseded by #141, which implements the changes in this PR but without moving the definition of Domain. That makes it easier to experiment with. We can revisit moving the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to move the definition of Domain to the DomainSetsCore package.
This PR is not meant to be merged yet, only after DomainSetsCore has been registered and IntervalSets has been updated.