Skip to content

Conversation

@ashryaagr
Copy link
Contributor

Initial start for the UCI Dataset Airfoil. I will further add code for plotting and scaling the input using ZScoreTransform from ScikitLearn.jl.

@tlienart
Copy link
Collaborator

tlienart commented Mar 31, 2020

Hello! thanks for this, it's a good start. I would suggest:

  1. adding a few rounds of hyperparameter tuning with cross validation
  2. adding a comparison with another classifier

yes plots would be very welcome too, thanks 👍

PS: the ZScoreTransform is not available; you can either add it directly to MLJModels or code it yourself or use another available transformer

@tlienart
Copy link
Collaborator

tlienart commented Apr 1, 2020

Readme changes are all fine by me, thanks!

@ashryaagr
Copy link
Contributor Author

@tlienart I have added the comparison of DecisionTreeRegressor with RandomForestRegressor and have performed hyperparameter tuning too. I have made use of Standardizer and also plotted a heatmap.
Could you please review the same.

@tlienart
Copy link
Collaborator

tlienart commented Apr 6, 2020

Thanks a lot for your contribution @ashryaagr , looks good to me at first glance, I'll do another full depth pass within the next few days. Cheers!

@tlienart tlienart self-assigned this Apr 6, 2020
@tlienart
Copy link
Collaborator

Sorry for the delay, there seems to be a bug in how CSV reads requests like this, the line to recover the data doesn't seem to work anymore.

@tlienart
Copy link
Collaborator

nvm, it's an issue with CSV, fixed by upgrading.

@tlienart
Copy link
Collaborator

tlienart commented Apr 16, 2020

ok that looks good, I've done a few fixes/changes and added your name at the top (thanks!!) and will merge this.

I'll wait for https://travis-ci.com/github/alan-turing-institute/MLJTutorials/builds/160590950 to pass first.

At least locally, updating everything, it works. so should be good

@tlienart tlienart mentioned this pull request Apr 16, 2020
@tlienart
Copy link
Collaborator

closing in favour of #51 , thanks!

@tlienart tlienart closed this Apr 16, 2020
@ablaom
Copy link
Member

ablaom commented Apr 18, 2020

Thanks for this both @tlienart @ashryaagr ! 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants