refactor(models): align device parsing with DeviceResponseDto + nested state/location models#6
Open
kermz wants to merge 1 commit intoJonneDatanen:mainfrom
Open
refactor(models): align device parsing with DeviceResponseDto + nested state/location models#6kermz wants to merge 1 commit intoJonneDatanen:mainfrom
kermz wants to merge 1 commit intoJonneDatanen:mainfrom
Conversation
…ion, and parameters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors device parsing to mirror the API response structure and strengthens integration coverage for mapping correctness.
What Changed
1. Refactored Models To Match API Shape
pythemo/models.py:DeviceDeviceStateDeviceParametersLocationResponseLockStateenumdevice.state.*.ATTRIBUTES) for each model and parse/update loops driven by those mappings.DeviceResponseDtomapping onDevice:Id,Name,DeviceId,DeviceAuth,ClientId,Location,EnvironmentId,EnvironmentName,Tags,ActiveScheduleId,TemperatureSchedule,SW,State.LocationResponseDtomapping ondevice.location.DeviceStateDtomapping ondevice.state.DeviceParametersmapping ondevice.state.device_parameters.2. State/Value Handling
0/1state flags:lights(Lights)frost_protection(FTS)LockStateenum parsing forLockwith tolerant fallback:3. Integration Test Expansion
tests/test_client.pyintegration mapping test to validate:DevicemappingLocationResponsemappingDeviceStatemappingDeviceParametersmappingStatekeysDeviceParameterskeysOK/FAIL).RAW REQUESTRAW RESPONSEFiles Updated
pythemo/models.pytests/test_client.pyREADME.mdNotes
device.state(instead of expecting flattened state fields directly onDevice).