Resolved storage dependency in shared package by moving the `useS…
#1014
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…torage
hook fromsharedtostorage`Priority*
Purpose of the PR*
The
sharedpackaged is described as code that's being shared between other packages and the main application. One application is to move type declarations intoshared. Which works unless you need a type for astorage. Thesharedpackaged held theuseStoragehook, which made it dependent onstoragebecause it imported types fromstorage, which in turn means that if you define a new type insharedand wanna use that in astorage, you'd end up with a circular dependency.Changes*
useStoragefrompackages/lib/shared/hookstopackages/storage/lib/hooks.Before the change one had to do:
Now:
and you can use types defined in the
sharedpackage inside yourstoragesHow to check the feature
Just do a code review, nothing changed visually and the changes aren't that big. Pretty straight forward.
Reference