Skip to content

fix duplicate loading in FeaturesFallbackReader #14667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 8, 2025
Merged

fix duplicate loading in FeaturesFallbackReader #14667

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4cc8d52
fix duplicate loading in FeaturesFallbackReader
C-K-Loan Oct 2, 2025
4643291
Improve fallback loader
DevinTDHa Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions src/main/scala/com/johnsnowlabs/nlp/ParamsAndFeaturesReadable.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,12 +88,8 @@ class FeaturesFallbackReader[T <: HasFeatures](

override def load(path: String): T = {
Try {
// Read params, features and model
val instance = baseReader.load(path)
loadFeatures(path, instance)
onRead(instance, path, sparkSession)

instance
// Read params, features and model via FeaturesReader.load
baseReader.load(path)
} match {
case Failure(_) =>
// TODO: Logger warn instead?
Expand All @@ -105,12 +101,6 @@ class FeaturesFallbackReader[T <: HasFeatures](
}
}

private def loadFeatures(path: String, instance: T): Unit = {
for (feature <- instance.features) {
val value = feature.deserialize(sparkSession, path, feature.name)
feature.setValue(value)
}
}
}

/** Enables loading models with params and features with a fallback mechanism. The `fallbackLoad`
Expand Down