Skip to content

Stop the game when stopping the Start & Debug run configuration #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
van800 merged 1 commit into from
May 13, 2020
Merged

Stop the game when stopping the Start & Debug run configuration #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions ...ain/kotlin/com/jetbrains/rider/plugins/godot/run/configurations/GodotDebugProfileState.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import com.intellij.openapi.diagnostic.Logger
import com.intellij.util.ui.UIUtil
import com.jetbrains.rd.platform.util.application
import com.jetbrains.rd.util.lifetime.Lifetime
import com.jetbrains.rd.util.lifetime.onTermination
import com.jetbrains.rdclient.util.idea.toIOFile
import com.jetbrains.rider.debugger.DebuggerHelperHost
import com.jetbrains.rider.debugger.DebuggerWorkerProcessHandler
Expand Down Expand Up @@ -36,14 +37,14 @@ class GodotDebugProfileState(private val remoteConfiguration: GodotDebugRunConfi
commandLine.environment.set("GODOT_MONO_DEBUGGER_AGENT", "--debugger-agent=transport=dt_socket,address=127.0.0.1:$godotPort,server=n,suspend=y")
commandLine.workDirectory = File(path).parentFile

ExternalConsoleMediator.createProcessHandler(commandLine)
val processHandler = ExternalConsoleMediator.createProcessHandler(commandLine)
processHandler.startNotify()

// todo: stop Godot after stopping Debug
// lifetime.onTermination {
// if (!processHandler.isProcessTerminated) {
// processHandler.destroyProcess()
// }
// }
lifetime.onTermination {
if (!processHandler.isProcessTerminated) {
processHandler.destroyProcess()
}
}
}
return super.execute(executor, runner, workerProcessHandler)
}
Expand Down